c# - Is there a way to make this more efficient? -


so working on text adventure improve programming skills (just beginner) , working on new combat system because old 1 boring. came across rock paper scissors system wanted used rock paper scissors system 5 options player choose from, , enemy or monster attacking player.

i used lot of if statements, didn't take long, i'm wondering if there's better way code more efficient, , not large.

        public static void resultsofmoves(string playermove, string monstermove, monster currentmonster, weapon currentweapon, armor currentarmor, player currentplayer)     {         //monster responses player         if (playermove == "dodge" && monstermove == "heavy"||monstermove == "stealth")         {             if (monstermove == "heavy") { monsterheavyattack(); }             if (monstermove == "stealth") { monsterstealthattack(); }         }         else if (playermove == "charge" && monstermove == "dodge"||monstermove == "stealth")         {             if (monstermove == "dodge") { monsterdodge(); }             if (monstermove == "stealth") { monsterstealthattack(); }         }         else if (playermove == "block" && monstermove == "charge" || monstermove == "dodge")         {             if (monstermove == "charge") { monsterchargeattack(); }             if (monstermove == "dodge") { monsterdodge(); }         }         else if (playermove == "heavy" && monstermove == "block" || monstermove == "charge")         {             if (monstermove == "block") { monsterblock(); }             if (monstermove == "charge") { monsterchargeattack(); }         }         else if (playermove == "stealth" && monstermove == "heavy" || monstermove == "block")         {             if (monstermove == "heavy") { monsterheavyattack(); }             if (monstermove == "block") { monsterblock(); }         }          //players responses monster         if (monstermove == "dodge" && playermove == "heavy" || playermove == "stealth")         {             if (playermove == "heavy") { monsterheavyattack(); }             if (playermove == "stealth") { monsterstealthattack(); }         }         else if (monstermove == "charge" && playermove == "dodge" || playermove == "stealth")         {             if (playermove == "dodge") { monsterdodge(); }             if (playermove == "stealth") { monsterstealthattack(); }         }         else if (monstermove == "block" && playermove == "charge" || playermove == "dodge")         {             if (playermove == "charge") { monsterchargeattack(); }             if (playermove == "dodge") { monsterdodge(); }         }         else if (monstermove == "heavy" && playermove == "block" || playermove == "charge")         {             if (playermove == "block") { monsterblock(); }             if (playermove == "charge") { monsterchargeattack(); }         }         else if (monstermove == "stealth" && playermove == "heavy" || playermove == "block")         {             if (playermove == "heavy") { monsterheavyattack(); }             if (playermove == "block") { monsterblock(); }         }      }

first create move enum, rather using strings:

public enum moves {     charge,     dodge,     heavy,     steath,     block }

next, use dictionary determine moves:

var moveresolution = new dictionary<tuple<moves, moves>, action> {     { new tuple<moves, moves>(moves.dodge, moves.heavy), monsterheavyattack },     { new tuple<moves, moves>(moves.dodge, moves.steath), monsterstealthattack },     { new tuple<moves, moves>(moves.charge, moves.dodge), monsterdodge },     ... };

then determine appropriate move, do:

var movecombination = new tuple<moves, moves>(playermove, monstermove); if (moveresolution.containskey(movecombination)) {     moveresolution[movecombination](); }

this code further improved replacing lazy tuple<moves, moves> movecombination struct. note, use struct ensure moveresolution.containskey(movecombination) part works need compare value, not reference.


Comments

Post a Comment

Popular posts from this blog

angularjs - ADAL JS Angular- WebAPI add a new role claim to the token -

i have created angular spa webapi backend using adal js authentication.as there no roles in ad, need manually add role claims in order give users access different api controllers. the roles stored in database. expecting inject claim through call webapi after authentication ad. webapi code might this. identity.addclaim(new claim("role", "user")); var ticket = new authenticationticket(identity, props); var accesstoken = startup.oauthbeareroptions.accesstokenformat.protect(ticket); is possible replace adal idtoken new token? is viable solution or there other better way handle this? as initial token generated azuread, possible edit token add new claim? appreciated. graph api supporting group claims. see here: http://justazure.com/azure-active-directory-part-4-group-claims/ if @ examples on page, users assigned groups , app can check group in claims. in current version of portal, need app manifest , modify it.
Read more

node.js - Using Node without global install -

i'm working on few node & electron (atom shell) projects , i'm curious how them work without user having install node globally. i've seen few applications including node directory in project contains node.exe binary. how go setting node project use binary? edit: thought should add, i've searched everywhere answer this, unrelated results.
Read more

php - CakePHP HttpSockets send array of paramms -

i problem when make request (i can request). $link = 'http://uri/path/?param1=1&sid=2&sid=3&sid=4' $http = $httpsocket = new httpsocket(); $res = $httpsocket->get($link); if check request pr($http); i see : [line] => /url/path/?param1=1&sid%5b0%5d=2&sid%5b1%5d=3&sid%5b2%5d=4 http/1.1 and i'm getting empty response because server doesn't know parameters sid%5b0%5d=2 when try send parameters array : $data = array('param1' => '1', 'sid' => array('2','3', '4')); i see same changes %5b0%5d - additional indexes. how fix it? unfortunately , can not change server side, if send request in browser, i'll normal response in json format. when make request, can parameters this: $param1 = $_get['param1']; $sid= $_get['sid']; tip: use diferente names parameters. have multiples sid. use sid1, sid2, sid3... update: can parameters this:...
Read more